add quilt2 sbwf#11223
Merged
Merged
Conversation
LouisLeNezet
requested changes
Apr 20, 2026
Contributor
LouisLeNezet
left a comment
LouisLeNezet
left a comment
There was a problem hiding this comment.
Just a few small changes, but good to go otherwise !
…mporarily the region and therefore shouldn't be used in the meta map
LouisLeNezet
approved these changes
May 11, 2026
Contributor
LouisLeNezet
left a comment
LouisLeNezet
left a comment
There was a problem hiding this comment.
The ch_versions channel is no more needed.
Could you remove it from the different files ?
Otherwise LGTM !
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
manascripts
pushed a commit
to manascripts/modules
that referenced
this pull request
May 21, 2026
* add quilt2 sbwf * publishDir not necessary for the unittest * add a line to explain that the regionout key will be used to store temporarily the region and therefore shouldn't be used in the meta map * QUILT2 uses topics for versions * Add a test with the optional bamnames input file to ensure it does work properly * Update subworkflows/nf-core/bam_impute_quilt2/tests/main.nf.test Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> * fix linting --------- Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nf-core/phaseimpute#282